Allow edit operation to reuse proxy port of the old proxy #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3200 +/- ##
==========================================
+ Coverage 57.11% 57.18% +0.07%
==========================================
Files 346 346
Lines 34314 34327 +13
==========================================
+ Hits 19598 19631 +33
+ Misses 13091 13061 -30
- Partials 1625 1635 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prior to this PR, the edit API endpoint would not allow the proxy port to be reused. This was because the run config validation happened before stopping the old instance of the workload, and thus the port appeared to be still in use. This PR adds some tweaks to the validation logic to allow port reuse for the edit case. It also tweaks the edit endpoint to reuse the previous port of the workload if a proxy port is not specified - this feels like a more natural behaviour than picking a new random port. This implementation also allows a new port to be selected if the caller desires. There is a potential race condition in this implementation: if a new workload is created between the termination of the previous proxy process and the creation of the new one, it could potentially "steal" the port and cause the edit to fail after validation has completed. I think this is an acceptable risk for now - fixing it will require us to build some kind of locking mechanism for ports.
dmjb
force-pushed
the
edit-api-port-reuse
branch
from
35de612 to
163d8f9
Compare
github-actions
bot
added
size/M
jerm-dro
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the edit API endpoint would not allow the proxy port to be reused. This was because the run config validation happened before stopping the old instance of the workload, and thus the port appeared to be still in use.
This PR adds some tweaks to the validation logic to allow port reuse for the edit case. It also tweaks the edit endpoint to reuse the previous port of the workload if a proxy port is not specified - this feels like a more natural behaviour than picking a new random port. This implementation also allows a new port to be selected if the caller desires.
There is a potential race condition in this implementation: if a new workload is created between the termination of the previous proxy process and the creation of the new one, it could potentially "steal" the port and cause the edit to fail after validation has completed. I think this is an acceptable risk for now - fixing it will require us to build some kind of locking mechanism for ports.
Fixes: #3182